Return-Path: X-Original-To: apmail-jackrabbit-dev-archive@www.apache.org Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 54C4710759 for ; Wed, 28 Aug 2013 11:50:58 +0000 (UTC) Received: (qmail 1294 invoked by uid 500); 28 Aug 2013 11:50:57 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 1252 invoked by uid 500); 28 Aug 2013 11:50:53 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 909 invoked by uid 99); 28 Aug 2013 11:50:51 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Aug 2013 11:50:51 +0000 Date: Wed, 28 Aug 2013 11:50:51 +0000 (UTC) From: "Thomas Mueller (JIRA)" To: dev@jackrabbit.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (JCR-3652) Bundle serialization broken MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/JCR-3652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752315#comment-13752315 ] Thomas Mueller commented on JCR-3652: ------------------------------------- Fixed in revision 1518170 (trunk), revision 1518118, 1518122 (2.4 branch). > Bundle serialization broken > --------------------------- > > Key: JCR-3652 > URL: https://issues.apache.org/jira/browse/JCR-3652 > Project: Jackrabbit Content Repository > Issue Type: New Feature > Components: jackrabbit-core > Reporter: Thomas Mueller > Assignee: Thomas Mueller > Priority: Minor > Fix For: 2.4.4, 2.7.1 > > Attachments: JCR-3652-b.patch, JCR-3652.patch, JCR-3652-test-case.patch > > > I have got a strange case where some node bundle is broken, seemingly because a byte is missing. I can't explain the missing byte, but it is reproducible, meaning that writing the bundles again will break them again. There are 11 broken bundles, 10 of them have the size 480 bytes and one is slightly larger. It is always a boolean property value that is missing, always the value for the property jcr:isCheckedOut. > As a (temporary) solution, and to help analyze what the problem might be, I will create a patch that does the following: > * When serializing a bundle, check if the byte array can be de-serialized. If not, then try again. Starting with the 3th try, use a slower variant where before and after writing the boolean value the buffer is flushed. I'm aware that ByteArrayOutputStream.flush doesn't do much, but maybe it solves the problem (let's see) if the problem is related to a JVM issue. > * If de-serializing a bundle fails, check if it's because of a missing boolean property value. If yes, insert the missing byte. > I have also added some log messages (warning / error) to help analyze the problem. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira