Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Received-SPF: pass (athena.apache.org: domain of anchela@adobe.com designates
 64.18.1.78 as permitted sender)
From: Angela Schreiber <anchela@adobe.com>
To: "dev@jackrabbit.apache.org" <dev@jackrabbit.apache.org>
Date: Thu, 25 Jul 2013 08:39:41 +0100
Subject: Re: [jcr2spi] RepositoryException lost in ItemManager#nodeExists
Thread-Topic: [jcr2spi] RepositoryException lost in ItemManager#nodeExists
Thread-Index: Ac6JCiB7yfOkEt/ITMKaPEf/N6qCQw==
Message-ID: <CE16A263.4FFF%anchela@adobe.com>
In-Reply-To: 
 <CAHCW-mnF-EgKGX90XEXwER2V5OxVDiWnRB7jYWm5cUf4Aj=Fpg@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: Microsoft-MacOutlook/14.3.2.130206
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

hi chetan

i wouldn't do that as we generally avoid runtimeexceptions in jackrabbit.
instead i would log an error.


angela

On 7/24/13 3:01 PM, "Chetan Mehrotra" <chetan.mehrotra@gmail.com> wrote:

>Looking at the code [1]
>
>    /**
>     * @see ItemManager#nodeExists(Path)
>     */
>    public boolean nodeExists(Path path) {
>        try {
>            // session-sanity & permissions are checked upon
>itemExists(ItemState)
>            NodeState nodeState =3D hierMgr.getNodeState(path);
>            return itemExists(nodeState);
>        } catch (PathNotFoundException pnfe) {
>            return false;
>        } catch (ItemNotFoundException infe) {
>            return false;
>        } catch (RepositoryException re) {
>            return false;
>        }
>    }
>
>The catch block for RepositoryException should probably wrap the
>exception as a RuntimeException as it might happen for unknown reason.
>Changing this might break backward compatibility. Would it be fine to
>do that?
>
>@abhinav - Can you open a bug for this?
>
>[1]=20
>https://github.com/apache/jackrabbit/blob/trunk/jackrabbit-jcr2spi/src/mai
>n/java/org/apache/jackrabbit/jcr2spi/ItemManagerImpl.java#L115
>Chetan Mehrotra
>
>
>On Tue, Jul 23, 2013 at 7:42 PM, Abhinav Atul <aatul@adobe.com> wrote:
>> Just in case if this would be the right place to find a solution.
>>Please let me know if anything is unclear.
>>
>> Thanks
>> Abhinav
>>
>> -----Original Message-----
>> From: Abhinav Atul [mailto:aatul@adobe.com]
>> Sent: 22 July 2013 14:58
>> To: Jackrabbit Users
>> Subject: [jcr2spi] RepositoryException lost in ItemManager#nodeExists
>>
>> Hi,
>>                 I am trying to implement a synchronization service
>>using the jcr connector for Documentum. The issue I am facing is if the
>>Documentum server becomes non-responsive while trying to check if a node
>>has been updated or deleted at Documentum, the RepositoryException is
>>lost in ItemManagerImpl#nodeExists and the synchronization service is
>>communicated that the node does not exists which may not be the case.
>>Could the RepositoryException be communicated further?
>>
>> Thanks
>> Abhinav
>>