jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergiy Shyrkov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCR-3556) IndexingConfigurationImpl.getAggregateRules() should return null in case no aggregate rules are configured
Date Wed, 03 Apr 2013 15:17:15 GMT

    [ https://issues.apache.org/jira/browse/JCR-3556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620987#comment-13620987
] 

Sergiy Shyrkov commented on JCR-3556:
-------------------------------------

Thank you for a quick fix Marcel!
                
> IndexingConfigurationImpl.getAggregateRules() should return null in case no aggregate
rules are configured
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: JCR-3556
>                 URL: https://issues.apache.org/jira/browse/JCR-3556
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: indexing, jackrabbit-core
>    Affects Versions: 2.2.13, 2.4.3, 2.5.3, 2.6
>            Reporter: Sergiy Shyrkov
>            Priority: Minor
>             Fix For: 2.7
>
>
> Right now the IndexingConfigurationImpl.getAggregateRules() returns an empty array in
case no rules are configured as this it is initialized in the init() method as follows:
> aggregateRules = idxAggregates.toArray(new AggregateRule[idxAggregates.size()]);
> so it is never null, but rather an empty array.
> This causes small overhead when updating index in case no aggregate rules are configured
(in our case on the version store).
> The org.apache.jackrabbit.core.query.lucene.SearchIndex.retrieveAggregateRoot(Set<NodeId>,
Map<NodeId, NodeState>) method opens the reader and searches for terms (_:AGGR_NODE_UUID)
in any case.
> Could we change the IndexingConfigurationImpl.init() to set aggregateRules to null when
no aggregate rules are configured?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message