jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Mueller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCR-3547) Datastore GC doesn't reset updateModifiedDateOnAccess on datastore
Date Mon, 08 Apr 2013 10:55:16 GMT

    [ https://issues.apache.org/jira/browse/JCR-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625281#comment-13625281
] 

Thomas Mueller commented on JCR-3547:
-------------------------------------

> imo repository should forbid user to run two simultaneous gc.

That's true. I guess it would be the best solution. I can't currently think of a reason to
run two GCs concurrently.

>Maybe only reset if the current value matches the value in the GarbageCollector class?
can you explain it more? ds interface doesn't expose a method to retrieve this value. 

We could add a getter method. But thinking about it again, it wouldn't be good enough. Just
comparing the current value wouldn't be enough, as the second run (if we allow it) could be
started at the exact same time, or started right after calling the getter and before resetting
the value.

So I guess we should add code to disallow running GC concurrently. Do you want to do that,
or should I?
                
> Datastore GC doesn't reset updateModifiedDateOnAccess on datastore
> ------------------------------------------------------------------
>
>                 Key: JCR-3547
>                 URL: https://issues.apache.org/jira/browse/JCR-3547
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: 2.4, 2.5
>            Reporter: Shashank Gupta
>         Attachments: GarbageCollector.java.patch
>
>
> In mark phase, GC updates store.updateModifiedDateOnAccess with current time, so that
datastore updates record’s lastModified timestamp upon subsequent read/scan.
>  But  GC doesn't reset it to 0. So even after GC completes, datastore will continue updating
lastModified timestamp on read invocations and it will have performance impact. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message