jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cédric Damioli (JIRA) <j...@apache.org>
Subject [jira] [Commented] (JCR-3402) getSize() returning too many often -1
Date Wed, 27 Feb 2013 22:15:13 GMT

    [ https://issues.apache.org/jira/browse/JCR-3402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13588843#comment-13588843
] 

Cédric Damioli commented on JCR-3402:
-------------------------------------

I would be very excited to train my new commit karma with this patch ;)
But I'd like to get review/feedback from others, to ensure I've not broken anything !

Or should I commit as is (all tests pass) and wait for later feedback ?

                
> getSize() returning too many often -1
> -------------------------------------
>
>                 Key: JCR-3402
>                 URL: https://issues.apache.org/jira/browse/JCR-3402
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>            Reporter: Cédric Damioli
>         Attachments: QueryResultImpl.patch
>
>
> I've came accross the well known behaviour of query results returning -1 when asked for
getSize().
> While this is ok for optimization reasons (lazy results fetching), I just discovered
that the default "resultFetchSize" value in lucene queries is Integer.MAX_VALUE, so in all
queries I've ever executed, all results were actually fetched before asking for getSize, so
IMHO nothing prevents getSize() to return the real value instead -1

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message