From dev-return-36281-apmail-jackrabbit-dev-archive=jackrabbit.apache.org@jackrabbit.apache.org  Tue Sep 18 13:08:14 2012
Return-Path: <dev-return-36281-apmail-jackrabbit-dev-archive=jackrabbit.apache.org@jackrabbit.apache.org>
X-Original-To: apmail-jackrabbit-dev-archive@www.apache.org
Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 0310FDE9E
	for <apmail-jackrabbit-dev-archive@www.apache.org>; Tue, 18 Sep 2012 13:08:13 +0000 (UTC)
Received: (qmail 25008 invoked by uid 500); 18 Sep 2012 13:08:13 -0000
Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org
Received: (qmail 24645 invoked by uid 500); 18 Sep 2012 13:08:06 -0000
Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@jackrabbit.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@jackrabbit.apache.org>
List-Post: <mailto:dev@jackrabbit.apache.org>
List-Id: <dev.jackrabbit.apache.org>
Reply-To: dev@jackrabbit.apache.org
Delivered-To: mailing list dev@jackrabbit.apache.org
Received: (qmail 24609 invoked by uid 99); 18 Sep 2012 13:08:04 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Sep 2012 13:08:04 +0000
X-ASF-Spam-Status: No, hits=-0.7 required=5.0
	tests=RCVD_IN_DNSWL_LOW,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (nike.apache.org: domain of jukka.zitting@gmail.com designates 209.85.219.42 as permitted sender)
Received: from [209.85.219.42] (HELO mail-oa0-f42.google.com) (209.85.219.42)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Sep 2012 13:07:57 +0000
Received: by oagh2 with SMTP id h2so12439177oag.1
        for <dev@jackrabbit.apache.org>; Tue, 18 Sep 2012 06:07:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :content-type;
        bh=36yknQvdhLvDA0EaE9ae/sk1Ys2+QZTRBn5cgWdPit8=;
        b=A1hQWOOlUwcWy7UT7PvSfpAlcqpa/gqOZbt6PTBWtoaH62DoQrghnu0+9Pq0TLdxpS
         Chce1tSs0iUW+VEOa80EyDJyTxx9M9G/dRMnTDuC11dDzMNINLe+RVCeSBHtc87Zk4Ru
         KRc0+HvRN/od9q/KzsM+ocOIoWT8jaCVKeeZTzsYB3ow9dhYpADgFCY7P427biG5T/Ru
         kNzgCc6p3IeHt68gGryvmtdl/6piZ6BgN2+x4rHocfH/2WLYM7vXZKZtelXaqgvPZSK6
         tI8jodX2NBWjODuKAwgIFwIRI013WLJ3VVKv+NQpSIGS9lcI3VtLWl2hHexmOMo1F3eV
         z6Jg==
Received: by 10.182.37.41 with SMTP id v9mr172820obj.23.1347973656537; Tue, 18
 Sep 2012 06:07:36 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.76.11.198 with HTTP; Tue, 18 Sep 2012 06:07:15 -0700 (PDT)
In-Reply-To: <CAHCW-m=-a1bZT29+t_qSG+xkMWrDs_iJcBBGgvNMpSLNYRdPSA@mail.gmail.com>
References: <CAHCW-m=-a1bZT29+t_qSG+xkMWrDs_iJcBBGgvNMpSLNYRdPSA@mail.gmail.com>
From: Jukka Zitting <jukka.zitting@gmail.com>
Date: Tue, 18 Sep 2012 15:07:15 +0200
Message-ID: <CAOFYJNYp6mNYcDgPCMnxQprxTaetFhDS+04mQdSY_iOrjzCyZQ@mail.gmail.com>
Subject: Re: Improving Jackrabbit integration with OSGi - JAAS
To: dev@jackrabbit.apache.org
Content-Type: text/plain; charset=ISO-8859-1

Hi,

On Mon, Sep 10, 2012 at 5:28 PM, Chetan Mehrotra
<chetan.mehrotra@gmail.com> wrote:
> At high level following changes were done in Jackrabbit
> * Make use of new method
> Configuration.getInstance(ConfigAlgoName,InputParams,ProviderName) to
> obtain JAAS config in JAASAuthContext class to fetch configuration
> * Expose a new attribute jaasConfigProviderName in Security element of
> repository configuration.

I'm not entirely convinced that we need these extra options. Couldn't
you simply add an extra OsgiLoginModule class that's configured like
this:

    <LoginModule class="...OsgiLoginModule">
      ...
    </LoginModule>

That LoginModule implementation should be able to encapsulate all the
proposed extra logic.

BR,

Jukka Zitting