From dev-return-36267-apmail-jackrabbit-dev-archive=jackrabbit.apache.org@jackrabbit.apache.org Mon Sep 17 16:07:08 2012 Return-Path: X-Original-To: apmail-jackrabbit-dev-archive@www.apache.org Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 09394D920 for ; Mon, 17 Sep 2012 16:07:08 +0000 (UTC) Received: (qmail 17238 invoked by uid 500); 17 Sep 2012 16:07:07 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 17132 invoked by uid 500); 17 Sep 2012 16:07:07 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 17125 invoked by uid 99); 17 Sep 2012 16:07:07 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Sep 2012 16:07:07 +0000 Date: Tue, 18 Sep 2012 03:07:07 +1100 (NCT) From: "Bart van der Schans (JIRA)" To: dev@jackrabbit.apache.org Message-ID: <2097821428.88225.1347898027749.JavaMail.jiratomcat@arcas> In-Reply-To: <2038232868.86743.1347866827989.JavaMail.jiratomcat@arcas> Subject: [jira] [Commented] (JCR-3426) Log warning when changes are performed with event notification thread MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/JCR-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457112#comment-13457112 ] Bart van der Schans commented on JCR-3426: ------------------------------------------ If there are valid (exceptional) use cases for using the notification thread to make changes, then logging the full stack trace on WARN might be a bit too verbose. In that case we might consider logging the full stack only on debug level with a reference to it in the warning with something like: "full stack trace available on debug" > Log warning when changes are performed with event notification thread > --------------------------------------------------------------------- > > Key: JCR-3426 > URL: https://issues.apache.org/jira/browse/JCR-3426 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Reporter: Marcel Reutegger > Assignee: Marcel Reutegger > Priority: Minor > Attachments: JCR-3426.patch > > > Using the event notification thread (this is the thread calling the > onEvent() method of an EventListener implementation) to perform changes > on the repository is dangerous because it is a rather expensive call > and may cause the event queue to fill up. I think it would be good if > the repository logs a warning with a stack trace in this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira