jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Unico Hommes (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (JCR-3434) EventJournal#skipTo() broken
Date Sat, 29 Sep 2012 08:02:07 GMT

     [ https://issues.apache.org/jira/browse/JCR-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Unico Hommes resolved JCR-3434.
-------------------------------

    Resolution: Fixed
    
> EventJournal#skipTo() broken
> ----------------------------
>
>                 Key: JCR-3434
>                 URL: https://issues.apache.org/jira/browse/JCR-3434
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: 2.2.12, 2.4.3, 2.5.2
>            Reporter: Lars Michele
>            Assignee: Unico Hommes
>             Fix For: 2.2.13, 2.4.4, 2.5.3
>
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> There is a little typo in the implementation of EventJournal#skipTo method which makes
it pretty useless because it is skipping always to the last EventBundle. I attach the patch
inlined because it is really small:
> Index: src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java
> ===================================================================
> --- src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java	(revision
1391154)
> +++ src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java	(working
copy)
> @@ -135,7 +135,7 @@
>          // get skip map for this journal
>          SortedMap<Long, Long> skipMap = getSkipMap();
>          synchronized (skipMap) {
> -            SortedMap<Long, Long> head = skipMap.headMap(new Long(time));
> +            SortedMap<Long, Long> head = skipMap.headMap(new Long(date));
>              if (!head.isEmpty()) {
>                  eventBundleBuffer.clear();
>                  lastRevision = head.get(head.lastKey());

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message