Return-Path: X-Original-To: apmail-jackrabbit-dev-archive@www.apache.org Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 489C6D335 for ; Fri, 3 Aug 2012 09:19:06 +0000 (UTC) Received: (qmail 98451 invoked by uid 500); 3 Aug 2012 09:19:04 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 97994 invoked by uid 500); 3 Aug 2012 09:19:04 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 97938 invoked by uid 99); 3 Aug 2012 09:19:03 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Aug 2012 09:19:03 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id EFE9614052C for ; Fri, 3 Aug 2012 09:19:02 +0000 (UTC) Date: Fri, 3 Aug 2012 09:19:02 +0000 (UTC) From: "Alex Parvulescu (JIRA)" To: dev@jackrabbit.apache.org Message-ID: <217112385.9386.1343985542985.JavaMail.jiratomcat@issues-vm> In-Reply-To: <622078880.90482.1343039976032.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Closed] (JCR-3396) Simplify the code when possible MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/JCR-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Parvulescu closed JCR-3396. -------------------------------- > Simplify the code when possible > ------------------------------- > > Key: JCR-3396 > URL: https://issues.apache.org/jira/browse/JCR-3396 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Reporter: Thomas Mueller > Priority: Minor > > Sometimes it's possible to simplify the code, for example: > - making methods static when possible, so a reader knows the method doesn't change the state of an object > - the "else" is unnecessary if the "if" block always returns -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira