Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Date: Thu, 30 Aug 2012 03:24:10 +1100 (NCT)
From: "Marcel Reutegger (JIRA)" <jira@apache.org>
To: dev@jackrabbit.apache.org
Message-ID: <1074438999.12355.1346257450355.JavaMail.jiratomcat@arcas>
In-Reply-To: <1042990924.3749.1344421090349.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Comment Edited] (JCR-3406) Journal doUnlock sometimes not
 called on repository shutdown
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/JCR-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444162#comment-13444162 ] 

Marcel Reutegger edited comment on JCR-3406 at 8/30/12 3:23 AM:
----------------------------------------------------------------

This change produces warnings on startup. It would be better to also consider the record attribute:

29.08.2012 16:38:10 *WARN * [main] ClusterNode: No record prepared. (ClusterNode.java, line 672)

                
      was (Author: mreutegg):
    This change produces warnings on startup. It would be better to also consider the record attribute.
                  
> Journal doUnlock sometimes not called on repository shutdown
> ------------------------------------------------------------
>
>                 Key: JCR-3406
>                 URL: https://issues.apache.org/jira/browse/JCR-3406
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>            Reporter: Thomas Mueller
>            Assignee: Thomas Mueller
>             Fix For: 2.6
>
>
> When the repository is shut down, the method AbstractJournal.doUnlock(boolean successful) is sometimes not called. The method Journal.close is called, but when the journal implementation uses a reentrant lock it can't unlock because close is called from a different thread.
> The reason for not calling doUnlock is that ClusterNode.stop() sets the status to "stopped", which causes all WorkspaceUpdateChannel methods to not work, including updateCommitted and updateCancelled. Therefore, it is possible that an operation is started but never completed nor cancelled.
> To solve the issue, I found that it is enough to let updateCommitted and updateCancelled to complete, so that operations that are in progress can finish.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira