Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Date: Tue, 3 Jul 2012 09:13:11 +0000 (UTC)
From: "Marcel Reutegger (JIRA)" <jira@apache.org>
To: dev@jackrabbit.apache.org
Message-ID: <1290970972.161.1341306791331.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <609819115.11.1341224782704.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (JCR-3369) Garbage collector improvements
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/JCR-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405708#comment-13405708 ] 

Marcel Reutegger commented on JCR-3369:
---------------------------------------

One thing I noticed in the logs: the session in GarbageCollector.Listener is not closed.

Fixed in revision: 1356630
                
> Garbage collector improvements
> ------------------------------
>
>                 Key: JCR-3369
>                 URL: https://issues.apache.org/jira/browse/JCR-3369
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Mete Atamel
>         Attachments: JCR-3369-2.2.patch, JCR-3369-trunk.patch
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> We identified a number of improvements to garbage collector related code to make it more robust, specifically:
> 1- As discussed in JCR-3340, when GC goes through nodes, it can encounter a lot of ItemStateExceptions. Currently, stack trace of these exceptions are not logged and this makes debugging difficult. Instead, ItemStateExceptions should at least be logged with full stack trace every 1 minute or so.
> 2- As discussed in JCR-3341, GC does not fail fast if there is a problem and it should.
> 3- Session usage in the GC is problematic. The session in GC is used for traversing the content and marking the binaries, but the listener in that class uses the same session as well, when a node is added. GC should rather use a separate session in onEvent() to avoid concurrent use.
> 4- GC listens for NODE_ADDED event for moved nodes but instead it should listen for NODE_MOVED.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira