Return-Path: X-Original-To: apmail-jackrabbit-dev-archive@www.apache.org Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C53609883 for ; Wed, 13 Jun 2012 12:49:47 +0000 (UTC) Received: (qmail 91424 invoked by uid 500); 13 Jun 2012 12:49:47 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 90678 invoked by uid 500); 13 Jun 2012 12:49:45 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 90634 invoked by uid 99); 13 Jun 2012 12:49:43 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jun 2012 12:49:43 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id 4AB5514285F for ; Wed, 13 Jun 2012 12:49:43 +0000 (UTC) Date: Wed, 13 Jun 2012 12:49:43 +0000 (UTC) From: "Julian Reschke (JIRA)" To: dev@jackrabbit.apache.org Message-ID: <594771141.12464.1339591783308.JavaMail.jiratomcat@issues-vm> In-Reply-To: <509444105.65025.1303148885765.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (JCR-2950) CachingEntryCollector ineffective if number of accessed policies exceeds cache size MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/JCR-2950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated JCR-2950: -------------------------------- Attachment: JCR-2950-refactor+rootnode_4.patch This fixes the assert and augments the test cases. > CachingEntryCollector ineffective if number of accessed policies exceeds cache size > ----------------------------------------------------------------------------------- > > Key: JCR-2950 > URL: https://issues.apache.org/jira/browse/JCR-2950 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: jackrabbit-core, security > Affects Versions: 2.2.4 > Environment: Repository with ACEs > 1000 > Reporter: Honwai Wong > Assignee: angela > Attachments: CachingEntryCollector.ConcurrentCache-trunk.patch, JCR-2950-refactor+rootnode.patch, JCR-2950-refactor+rootnode_2.patch , JCR-2950-refactor+rootnode_3.patch, JCR-2950-refactor+rootnode_4.patch, JCR-2950-refactor.patch > > > The CachingEntryCollector's cache (LRUMap, max size: 1000) seems to become ineffective in case there are more than 1000 ACEs present in the repository. Since access to the cache is synchronized, many threads are basically blocked, waiting to get access to the cache. > Java callstack: > at org/apache/jackrabbit/core/security/authorization/acl/CachingEntryCollector.getEntries(CachingEntryCollector.java:99(Compiled Code)) > at org/apache/jackrabbit/core/security/authorization/acl/EntryCollector.collectEntries(EntryCollector.java:134(Compiled Code)) > at org/apache/jackrabbit/core/security/authorization/acl/CompiledPermissionsImpl.canRead(CompiledPermissionsImpl.java:250(Compiled Code)) > at org/apache/jackrabbit/core/security/DefaultAccessManager.canRead(DefaultAccessManager.java:251(Compiled Code)) > at org/apache/jackrabbit/core/ItemManager.canRead(ItemManager.java:426(Compiled Code)) > at org/apache/jackrabbit/core/ItemManager.createItemData(ItemManager.java(Compiled Code)) > at org/apache/jackrabbit/core/ItemManager.getItemData(ItemManager.java:379(Compiled Code)) > at org/apache/jackrabbit/core/ItemManager.itemExists(ItemManager.java:292(Compiled Code)) > at org/apache/jackrabbit/core/ItemManager.itemExists(ItemManager.java:464(Compiled Code)) > at org/apache/jackrabbit/core/session/SessionItemOperation$1.perform(SessionItemOperation.java:49(Compiled Code)) > at org/apache/jackrabbit/core/session/SessionItemOperation$1.perform(SessionItemOperation.java:46(Compiled Code)) > at org/apache/jackrabbit/core/session/SessionItemOperation.perform(SessionItemOperation.java:187(Compiled Code)) > at org/apache/jackrabbit/core/session/SessionState.perform(SessionState.java:200(Compiled Code)) > at org/apache/jackrabbit/core/SessionImpl.perform(SessionImpl.java:355(Compiled Code)) > at org/apache/jackrabbit/core/SessionImpl.itemExists(SessionImpl.java:751(Compiled Code)) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira