From dev-return-35494-apmail-jackrabbit-dev-archive=jackrabbit.apache.org@jackrabbit.apache.org Fri Jun 22 17:28:43 2012 Return-Path: X-Original-To: apmail-jackrabbit-dev-archive@www.apache.org Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CB1FB97B2 for ; Fri, 22 Jun 2012 17:28:43 +0000 (UTC) Received: (qmail 35012 invoked by uid 500); 22 Jun 2012 17:28:43 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 34920 invoked by uid 500); 22 Jun 2012 17:28:43 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 34819 invoked by uid 99); 22 Jun 2012 17:28:43 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Jun 2012 17:28:43 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id F1EEF1427F2 for ; Fri, 22 Jun 2012 17:28:42 +0000 (UTC) Date: Fri, 22 Jun 2012 17:28:42 +0000 (UTC) From: "Alex Parvulescu (JIRA)" To: dev@jackrabbit.apache.org Message-ID: <1744688651.44653.1340386122992.JavaMail.jiratomcat@issues-vm> In-Reply-To: <1797466871.44639.1340385882943.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Updated] (JCR-3357) Allow TimeSeries to track external counters MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/JCR-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Parvulescu updated JCR-3357: --------------------------------- Attachment: JCR-3357.patch attached proposed patch. I'm not 100% sure about the RepositoryStatisticsImpl#createDelegatingRecorder. It checks for potential race condition, if somebody else created a recorder with the same name by calling #getOrCreateRecorder and updates to the good delegating recorder, but it leaves the original caller with a potential stale counter reference. I prefer stale counter that can be refreshed by calling #get again instead of a read-only 0 value counter. feedback is welcome. > Allow TimeSeries to track external counters > ------------------------------------------- > > Key: JCR-3357 > URL: https://issues.apache.org/jira/browse/JCR-3357 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: jackrabbit-core > Reporter: Alex Parvulescu > Assignee: Alex Parvulescu > Attachments: JCR-3357.patch > > > We should extend the current TimeSeries to be able to track external counters. > This would facilitate the exposure of potentially already existing information by simply wrapping it into counters that will then be tracked by a normal TimeSeries and exposed as a repository statistic. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira