Return-Path: X-Original-To: apmail-jackrabbit-dev-archive@www.apache.org Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B9DE6CFE6 for ; Sun, 27 May 2012 09:53:28 +0000 (UTC) Received: (qmail 66141 invoked by uid 500); 27 May 2012 09:53:26 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 65226 invoked by uid 500); 27 May 2012 09:53:25 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 64921 invoked by uid 99); 27 May 2012 09:53:24 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 May 2012 09:53:24 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id ABC01140C2C for ; Sun, 27 May 2012 09:53:24 +0000 (UTC) Date: Sun, 27 May 2012 09:53:24 +0000 (UTC) From: "Jukka Zitting (JIRA)" To: dev@jackrabbit.apache.org Message-ID: <1374693634.6921.1338112404705.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Updated] (JCR-2662) JCR unit tests for journaled observation do not check capabilities and require implementation, contrary to JCR 2.0 specification MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/JCR-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jukka Zitting updated JCR-2662: ------------------------------- Fix Version/s: (was: 2.6) 2.5 > JCR unit tests for journaled observation do not check capabilities and require implementation, contrary to JCR 2.0 specification > -------------------------------------------------------------------------------------------------------------------------------- > > Key: JCR-2662 > URL: https://issues.apache.org/jira/browse/JCR-2662 > Project: Jackrabbit Content Repository > Issue Type: Bug > Components: jackrabbit-jcr-tests, JCR 2.0 > Affects Versions: 2.4 > Reporter: Randall Hauch > Assignee: Julian Reschke > Fix For: 2.4.2, 2.5 > > Attachments: JCR-2662.patch > > > The org.apache.jackrabbit.test.api.observation.EventJournalTest class obtains the EventJournal from the observation manager, but does not check the capabilities of the JCR implementation before running these tests. Therefore, these tests always fail when run against any implementation that chooses not to implement the _optional_ journaled observation feature. > Per the second paragraph in chapter 12 of the JCR 2.0 specification, any implementation that does support journaled observation should have in its descriptors a value of "true" for the Repository.OPTION_JOURNALED_OBSERVATION_SUPPORTED key. See [1] > The EventJournalTest methods should check this value and skip their tests, or simply check that the two ObservationManager.getEventJournal(...) methods do return null references if the feature is not supported (per the JavaDoc, see [2] and [3]). > [1] http://www.day.com/specs/jcr/2.0/12_Observation.html > [2] http://www.day.com/maven/javax.jcr/javadocs/jcr-2.0/javax/jcr/observation/ObservationManager.html#getEventJournal() > [3] http://www.day.com/maven/javax.jcr/javadocs/jcr-2.0/javax/jcr/observation/ObservationManager.html#getEventJournal(int,%20java.lang.String,%20boolean,%20java.lang.String[],%20java.lang.String[]) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira