Return-Path: X-Original-To: apmail-jackrabbit-dev-archive@www.apache.org Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D2237CDAE for ; Wed, 9 May 2012 14:44:12 +0000 (UTC) Received: (qmail 12388 invoked by uid 500); 9 May 2012 14:44:12 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 12347 invoked by uid 500); 9 May 2012 14:44:12 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 12336 invoked by uid 99); 9 May 2012 14:44:12 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 May 2012 14:44:12 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 May 2012 14:44:10 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 2A5C943C616 for ; Wed, 9 May 2012 14:43:49 +0000 (UTC) Date: Wed, 9 May 2012 14:43:49 +0000 (UTC) From: "Mete Atamel (JIRA)" To: dev@jackrabbit.apache.org Message-ID: <1162402957.44551.1336574629175.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Created] (JCR-3303) ClusterNode's stopDelay should default to something other zero MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Mete Atamel created JCR-3303: -------------------------------- Summary: ClusterNode's stopDelay should default to something other zero Key: JCR-3303 URL: https://issues.apache.org/jira/browse/JCR-3303 Project: Jackrabbit Content Repository Issue Type: Bug Components: jackrabbit-core Reporter: Mete Atamel Priority: Minor ClusterNode has a stopDelay that defaults to zero. This is problematic because it's used in joining syncThread. SyncThread is supposed to be a daemon thread which means it's not supposed to block JVM shutdown. However, by joining syncThread with a default stopDelay of zero, ClusterNode can potentially wait for syncThread to finish its job forever. This effectively makes syncThread a non-daemon thread and that can definitely make ClusterNode#stop block forever if syncThread never finishes. Instead of defaulting to zero, I think it'd be better if stopDelay defaulted to something more reasonable like 2 * syncDelay. There's no need to make ClusterNode block forever for sync in any case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira