jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ard Schrijvers (JIRA)" <j...@apache.org>
Subject [jira] [Created] (OCM-48) DefaultCollectionConverterImpl should take nodetype into account for doInsertCollection and doUpdateCollection
Date Fri, 25 May 2012 09:42:24 GMT
Ard Schrijvers created OCM-48:
---------------------------------

             Summary: DefaultCollectionConverterImpl should take nodetype into account  for
doInsertCollection and doUpdateCollection
                 Key: OCM-48
                 URL: https://issues.apache.org/jira/browse/OCM-48
             Project: Jackrabbit OCM
          Issue Type: Bug
            Reporter: Ard Schrijvers
            Assignee: Ard Schrijvers


>From Will Scheidegger : 

Hi Ard

This is only very vaguely related to what you are doing,… but since you seem to have commit
rights on OCM and you will be working on it:

A long time ago I discussed a bug in the DefaultCollectionConverterImpl class [1]. It seems
like this bug still exists today [2]. I'm not sure, but I think I provided a patch back then.
In any case, the patch would be:

--- Base (BASE)
+++ Locally Modified (Based On LOCAL)
@@ -111,7 +111,7 @@
                    + collectionDescriptor.getFieldName() + " for the classdescriptor : "
+ collectionDescriptor.getClassDescriptor().getClassName());
        }

-        Node collectionNode = parentNode.addNode(jcrName);
+        Node collectionNode = parentNode.addNode(jcrName, collectionDescriptor.getJcrType());

        ClassDescriptor elementClassDescriptor = mapper.getClassDescriptorByClass( ReflectionUtils.forName(collectionDescriptor.getElementClassName()));

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message