Return-Path: X-Original-To: apmail-jackrabbit-dev-archive@www.apache.org Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 78A9B9C16 for ; Mon, 23 Apr 2012 09:04:21 +0000 (UTC) Received: (qmail 74153 invoked by uid 500); 23 Apr 2012 09:04:21 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 73967 invoked by uid 500); 23 Apr 2012 09:04:14 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 73743 invoked by uid 99); 23 Apr 2012 09:04:11 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Apr 2012 09:04:11 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Apr 2012 09:04:08 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id D032540965C for ; Mon, 23 Apr 2012 09:03:47 +0000 (UTC) Date: Mon, 23 Apr 2012 09:03:47 +0000 (UTC) From: "Horia Chiorean (JIRA)" To: dev@jackrabbit.apache.org Message-ID: <447243409.4238.1335171827854.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (JCR-2662) JCR unit tests for journaled observation do not check capabilities and require implementation, contrary to JCR 2.0 specification MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JCR-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Horia Chiorean updated JCR-2662: -------------------------------- Attachment: JCR-2662.patch > JCR unit tests for journaled observation do not check capabilities and require implementation, contrary to JCR 2.0 specification > -------------------------------------------------------------------------------------------------------------------------------- > > Key: JCR-2662 > URL: https://issues.apache.org/jira/browse/JCR-2662 > Project: Jackrabbit Content Repository > Issue Type: Bug > Components: jackrabbit-jcr-tests, JCR 2.0 > Affects Versions: 2.1 > Reporter: Randall Hauch > Attachments: JCR-2662.patch > > > The org.apache.jackrabbit.test.api.observation.EventJournalTest class obtains the EventJournal from the observation manager, but does not check the capabilities of the JCR implementation before running these tests. Therefore, these tests always fail when run against any implementation that chooses not to implement the _optional_ journaled observation feature. > Per the second paragraph in chapter 12 of the JCR 2.0 specification, any implementation that does support journaled observation should have in its descriptors a value of "true" for the Repository.OPTION_JOURNALED_OBSERVATION_SUPPORTED key. See [1] > The EventJournalTest methods should check this value and skip their tests, or simply check that the two ObservationManager.getEventJournal(...) methods do return null references if the feature is not supported (per the JavaDoc, see [2] and [3]). > [1] http://www.day.com/specs/jcr/2.0/12_Observation.html > [2] http://www.day.com/maven/javax.jcr/javadocs/jcr-2.0/javax/jcr/observation/ObservationManager.html#getEventJournal() > [3] http://www.day.com/maven/javax.jcr/javadocs/jcr-2.0/javax/jcr/observation/ObservationManager.html#getEventJournal(int,%20java.lang.String,%20boolean,%20java.lang.String[],%20java.lang.String[]) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira