Return-Path: X-Original-To: apmail-jackrabbit-dev-archive@www.apache.org Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2820695F5 for ; Fri, 2 Mar 2012 14:10:22 +0000 (UTC) Received: (qmail 39815 invoked by uid 500); 2 Mar 2012 14:10:21 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 39767 invoked by uid 500); 2 Mar 2012 14:10:21 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 39759 invoked by uid 99); 2 Mar 2012 14:10:21 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Mar 2012 14:10:21 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Mar 2012 14:10:19 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 85E20585A for ; Fri, 2 Mar 2012 14:09:58 +0000 (UTC) Date: Fri, 2 Mar 2012 14:09:58 +0000 (UTC) From: "Alex Parvulescu (Resolved) (JIRA)" To: dev@jackrabbit.apache.org Message-ID: <5411281.11977.1330697398549.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <737499877.11971.1330697398227.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Resolved] (JCR-3248) TimeoutHandler visitor should be extracted into a dedicated class MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JCR-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Parvulescu resolved JCR-3248. ---------------------------------- Resolution: Fixed Fix Version/s: 2.5 fixed in revision 1296214. > TimeoutHandler visitor should be extracted into a dedicated class > ----------------------------------------------------------------- > > Key: JCR-3248 > URL: https://issues.apache.org/jira/browse/JCR-3248 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: jackrabbit-core > Reporter: Alex Parvulescu > Priority: Minor > Fix For: 2.5 > > > This is a minor problem that I've stumbled upon when looking at a memory leak. > It seems that the TimeoutHandler thread runs each second and it uses a custom ElementVisitor to do its business. By creating a new instance of ElementVisitor each second this creates some garbage that could be avoided by using a predefined class. > Short story: during a unit test it creates 3x instances each second that have 16 bytes each. Having a dedicated visitor class creates just 3 instances for the lifespan of the repository. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira