Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Date: Fri, 2 Mar 2012 15:57:58 +0000 (UTC)
From: "Mete Atamel (Commented) (JIRA)" <jira@apache.org>
To: dev@jackrabbit.apache.org
Message-ID: 
 <1216977164.12408.1330703878117.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <884530714.10211.1330010329245.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (JCR-3243) RepositoryStatistics should be more
 flexible
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/JCR-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221007#comment-13221007 ] 

Mete Atamel commented on JCR-3243:
----------------------------------

Thanks for the feedback. Regarding getType method, yes, definitely, it makes more sense as a static method on Type enum. Regarding the iterator though, I'm not sure how to solve that, that's why I kind of left it the way it is. The problem is that the returned iterator has the following signature: "Entry<Type, TimeSeries>". As you know, with the changes, now we can have String as type and I cannot return those String based types from this iterator. I can change the iterator's signature to "Entry<String, TimeSeries>" and that would enable me to return all the entries but then I'd be changing a public method. So, I'm not sure which one is worse: return some of the values from the iterator or change a public method.  
                
> RepositoryStatistics should be more flexible
> --------------------------------------------
>
>                 Key: JCR-3243
>                 URL: https://issues.apache.org/jira/browse/JCR-3243
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-api, jackrabbit-core
>            Reporter: Mete Atamel
>            Priority: Minor
>         Attachments: JCR-3243-2.patch, JCR-3243-3.patch, JCR-3243.patch
>
>
> Right now, Jackrabbit reports TimeSeries for things like BUNDLE_READ_COUNTER, BUNDLE_WRITE_COUNTER, etc. but there is no way to extend Jackrabbit and report TimeSeries for additional properties. That's because the type of TimeSeries are defined in RepositoryStatistics class as Type enum. Enums in Java cannot be extended which limits to TimeSeries to the Types defined in RepositoryStatistics. 
> I suggest that RepositoryStatistics is improved to allow additional TimeSeries. One approach is to define an additional RepositoryStatistics#getType(String) method. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira