jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Guggisberg <stefan.guggisb...@gmail.com>
Subject Re: [jr3 Microkernel] equals() not symmetric
Date Fri, 10 Feb 2012 10:41:27 GMT
On Thu, Feb 9, 2012 at 11:45 PM, Michael Dürig <mduerig@apache.org> wrote:
>
> Hi,
>
> I stumbled upon this by chance: The equals method for the classes
> ChildNodeEntriesMap and ChildNodeEntry is not symmetric.

hmm, i am pretty sure they're symmetric, i.e.: a.equals(b) == b.equals(a)

or are you referring to the missing hashCode() override?
i admit that i've been lazy since those internal objects are not
intended to be used as keys for hash tables and sorts.

but you're probably right, it doesn't hurt to implement them :)

cheers
stefan

> This will most
> certainly lead to subtle bugs later on.
>
> Michael

Mime
View raw message