Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Message-ID: <4ED76F55.3030001@apache.org>
Date: Thu, 1 Dec 2011 12:13:09 +0000
From: =?ISO-8859-1?Q?Michael_D=FCrig?= <mduerig@apache.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6;
 rv:8.0) Gecko/20111105 Thunderbird/8.0
MIME-Version: 1.0
To: <dev@jackrabbit.apache.org>
Subject: Re: [jr3 microkernel] Write skew
References: <CAFBF1F9.98931%aklimets@adobe.com> <4ED63BEE.6010904@apache.org>
 <CAOFYJNYedNnWA4Z_NWAuGaJBEuav87fY330NXfKAf7_Apx-ruw@mail.gmail.com>
 <4ED751DC.8070606@apache.org>
 <CAOFYJNaN8=EH6bGTWNyB5SctqV+UaQA5LeEAuCH+S=etw1yM8A@mail.gmail.com>
In-Reply-To: 
 <CAOFYJNaN8=EH6bGTWNyB5SctqV+UaQA5LeEAuCH+S=etw1yM8A@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 8bit


On 1.12.11 12:05, Jukka Zitting wrote:
> Hi,
>
> On Thu, Dec 1, 2011 at 11:07 AM, Michael D�rig<mduerig@apache.org>  wrote:
>> Note however, that for the same reason we are currently not able to
>> guarantee node type consistency:
>> [...]
>> Both sessions will successfully complete since for each of them the
>> consistency property (nt:file cannot have a child named "foo"). holds.
>
> The save() implementation will need to do an internal refresh(true),
> check any type and other constraints, and only persist the changes if
> everything is OK.
>
> To prevent this from being a too big blocking operation, we can use
> optimistic locking by making the last step of the process conditional
> on the repository still being at the state it was when the
> refresh(true) call was made. Otherwise the refresh-check-persist cycle
> should be restarted.

But this will introduce a race condition. With other words: this only 
make the time window during which such a inconsistency could slip in 
smaller. I think what we'd really need is an atomic test and set operation.

Michael

>
> BR,
>
> Jukka Zitting