jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thomas Mueller <muel...@adobe.com>
Subject Re: [j3 Microkernel] commit method
Date Wed, 14 Dec 2011 15:24:14 GMT
Hi,

>>sounds reasonable. probably easy to support, i'll check the current
>> implementation.
>
>implemented in svn r1214161.

Actually, I would prefer if you also implement at least one test case.

> Modified:
> 
>jackrabbit/sandbox/microkernel/src/main/java/org/apache/jackrabbit/mk/Micr
>oKernelImpl.java
> 
>jackrabbit/sandbox/microkernel/src/main/java/org/apache/jackrabbit/mk/api/
>MicroKernel.java
> 
>jackrabbit/sandbox/microkernel/src/main/java/org/apache/jackrabbit/mk/json
>/JsopTokenizer.java
> 
>jackrabbit/sandbox/microkernel/src/main/java/org/apache/jackrabbit/mk/util
>/PathUtils.java


Implementing features without any test case is bad practice in my view.
Specially if it's changes in the API and changes in others peoples code.

Regards,
Thomas


Mime
View raw message