jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Guggisberg <stefan.guggisb...@gmail.com>
Subject Re: [j3 Microkernel] commit method
Date Wed, 14 Dec 2011 14:55:29 GMT
On Mon, Dec 12, 2011 at 10:36 AM, Stefan Guggisberg
<stefan.guggisberg@gmail.com> wrote:
> On Fri, Dec 9, 2011 at 3:13 PM, Michael Dürig <mduerig@apache.org> wrote:
>>
>> Hi,
>>
>> Currently the commit method look like this:
>>
>> String commit(String path, String jsonDiff, String revisionId, String
>> message)
>>
>> The path argument has to be an absolute path and the paths of the jsonDiff
>> operations are relative paths. The target path of the operations are
>> determined by concatenating the path with the paths of the jsonDiff
>> operations.
>>
>> To facilitate the usage of this API where only absolute paths are involved,
>> I suggest to expand the scope of the commit method such that the empty
>> string (or null?) is allowed for the path argument. In this case all
>> jsonDiff operations need to specify an absolute path.
>
> sounds reasonable. probably easy to support, i'll check the current
> implementation.

implemented in svn r1214161.

cheers
stefan

>
> cheers
> stefan
>
>>
>> Michael

Mime
View raw message