jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Parvulescu (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCR-3162) Index update overhead on cluster slave due to JCR-905
Date Tue, 13 Dec 2011 13:15:30 GMT

    [ https://issues.apache.org/jira/browse/JCR-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168354#comment-13168354
] 

Alex Parvulescu commented on JCR-3162:
--------------------------------------

hi, thanks for the feedback.

> I see that you moved the initial index creation from the SearchIndex to the MultiIndex.
This is how it was before JCR-1064, where we had to move it out of the MultiIndex. I'm not
sure if it is now safe to move the initial index creation trigger back to the SearchIndex...


I wasn't aware of that move. I can put it back, it just felt a bit off to have code that is
potentially internal to MultiIndex outside controlled by SearchIndex.

> The class ClusterNode imports the MultiIndex, though this is probably just minor because
it is not really required to compile the class, but only to resolve the javadoc reference
True. We can remove that import.

> More troublesome is the import of DbClusterTestJCR3162 in SearchManager. That doesn't
work because DbClusterTestJCR3162 is a test class. 
That is just the feature flag. It will be removed once we agree on what the code should look
like.

>Wouldn't it be sufficient to use the existing journal and cluster node interface to get
changes from a given revision?
I'm not aware of any such interface. You have the local revision number available, but not
the actual changes, that is why I've added the 'poll' operation.

Now I'm investigating a lock on Cluster.sync introduced by this patch, so I'll upload another
one soon that will take this feedback into consideration.
                
> Index update overhead on cluster slave due to JCR-905
> -----------------------------------------------------
>
>                 Key: JCR-3162
>                 URL: https://issues.apache.org/jira/browse/JCR-3162
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: clustering
>            Reporter: Alex Parvulescu
>            Priority: Minor
>         Attachments: JCR-3162-v2.patch, JCR-3162-v3.patch, JCR-3162.patch
>
>
> JCR-905 is a quick and dirty fix and causes overhead on a cluster slave node when it
processes revisions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message