jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig (Commented) (JIRA) <j...@apache.org>
Subject [jira] [Commented] (JCR-3165) Consolidate compare behaviour for Value(s) and Comparable(s)
Date Fri, 02 Dec 2011 10:29:40 GMT

    [ https://issues.apache.org/jira/browse/JCR-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161533#comment-13161533
] 

Michael Dürig commented on JCR-3165:
------------------------------------

Looks good to me. I quickly applied the patch and all tests passed. The only thing we could
probably do is to move all comparison related methods from the Utils class to a dedicated
utility class. I'm not too sure about this however. 
                
> Consolidate compare behaviour for Value(s) and Comparable(s)
> ------------------------------------------------------------
>
>                 Key: JCR-3165
>                 URL: https://issues.apache.org/jira/browse/JCR-3165
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: query
>            Reporter: Alex Parvulescu
>            Priority: Minor
>         Attachments: JCR-3165.patch
>
>
> There are 2 different implementations of Value comparison (ValueComparator and Util).
With the introduction of JCR-2906 which introduces arrays into the mix, I'd like to refactor
all of them into one place, namely o.a.j.core.query.lucene.Util.
> This will also allow for a wider scope of comparison for Value[], marked as TODO in the
ValueComparator class.
> Will attach patch shortly

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message