jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Dürig (Commented) (JIRA) <j...@apache.org>
Subject [jira] [Commented] (JCR-3170) Precompile JavaCC parsers in jackrabbit-spi-commons
Date Tue, 06 Dec 2011 11:25:39 GMT

    [ https://issues.apache.org/jira/browse/JCR-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163529#comment-13163529

Michael Dürig commented on JCR-3170:

> PS. For future reference: When changing the JavaCC sources, use "mvn clean install -Pjavacc"
in jackrabbit-spi-commons and commit the updated files. 

I'm almost sure this will backfire since people will forget about this. At the very least
we should put this note into the headers of all the JavaCC source files. 

However, is it really worth to trade correctness for convenience here? I feel the IDE pain
too. In fact I felt it for the past couple of years. Why the sudden hurry now?
> Precompile JavaCC parsers in jackrabbit-spi-commons
> ---------------------------------------------------
>                 Key: JCR-3170
>                 URL: https://issues.apache.org/jira/browse/JCR-3170
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-spi-commons
>            Reporter: Jukka Zitting
>            Assignee: Jukka Zitting
>            Priority: Minor
>              Labels: javacc
>             Fix For: 2.3.5
> The JavaCC-generated Java source files in jackrabbit-spi-commons require special configuration
when importing Jackrabbit sources to an IDE like Eclipse. To make IDE integration smoother
it would be nice if precompiled copies of the Java files existed the src/main/java folder.
> Precompiling the sources would also allow us to avoid the JavaCC processing step during
each Jackrabbit build. Instead we could have a separate profile for explicitly recompiling
the JavaCC sources when they have been modified. In the past three years that has happened
only once (JCR-952), so I think a bit of extra complexity there is justified by the simplification
we can achieve in normal builds and IDE integration.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message