jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Reutegger (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCR-3162) Index update overhead on cluster slave due to JCR-905
Date Wed, 14 Dec 2011 15:01:31 GMT

    [ https://issues.apache.org/jira/browse/JCR-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169417#comment-13169417
] 

Marcel Reutegger commented on JCR-3162:
---------------------------------------

Looks better now to me.

Some more comments:

- I would rather put getting the change log records into the SearchIndex, to not expand the
api of the cluster node unnecessarily.
- getChangeLogRecords() should check the producer id of the record
- processing of ClusterRecords can be done without instanceof check
- Record.getWorkspace() may return null for operations on the version storage (RepositoryImpl.getSearchManager()
should pass null as workspace name?)
- instance revision is also available from ClusterNode.getRevision()

I'll attach a patch.
                
> Index update overhead on cluster slave due to JCR-905
> -----------------------------------------------------
>
>                 Key: JCR-3162
>                 URL: https://issues.apache.org/jira/browse/JCR-3162
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: clustering
>            Reporter: Alex Parvulescu
>            Priority: Minor
>         Attachments: JCR-3162-v2.patch, JCR-3162-v3.patch, JCR-3162-v4.patch, JCR-3162.patch
>
>
> JCR-905 is a quick and dirty fix and causes overhead on a cluster slave node when it
processes revisions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message