jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julian Reschke (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCR-2542) spi2dav: EventFilters not respected
Date Tue, 15 Nov 2011 15:48:51 GMT

    [ https://issues.apache.org/jira/browse/JCR-2542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150564#comment-13150564
] 

Julian Reschke commented on JCR-2542:
-------------------------------------

Update on remaining issues:

(1) When creating the subscription, it would be good if we could check that the remote server
supports the extension added in r1202201. Custom repository descriptor?

(2) Filtering by noNocal

This is hard, as there's no one-to-one mapping between SPI Session(Info) and the JCR Sessions.

Proposal (I):

a) Extend the JCR Event with a method that answers the question: "is this an event for Session
x"? Technically this is simple as the EventState carries that information, we just need to
discuss the best way to expose this.

b) Let every SessionInfo create a unique identifier and send that one along with each request;
if we don't want to mint extension headers or re-use extension headers that we have we could
use the Link header again (as done for UserData)

c) Let the JCR server collect a mapping from SPI session identifiers to JCR sessions, so that
it can the calculate and return a isLocal flag in the POLL response

What's ugly is that this prevents us from re-using the same JCR session for different SPI
sessions (is this a problem?), and that it's not clear how long the mapping described in c)
needs to be maintained.

An alternate proposal (II)  would be to piggyback the information to the UserData, which of
course is ugly in that information will show up as user data which is not. A variant of this
(III) would be to extend ObservationManager and Events with a mechanism similar to UserData,
but not interfering with it.

Feedback appreciated...
                
> spi2dav: EventFilters not respected
> -----------------------------------
>
>                 Key: JCR-2542
>                 URL: https://issues.apache.org/jira/browse/JCR-2542
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-spi2dav, JCR 2.0, observation
>            Reporter: angela
>            Assignee: Julian Reschke
>         Attachments: JCR-2542-getInfo.diff, JCR-2542.diff, JCR-2542.diff
>
>
> i have the impression that the event filter passed to the event subscription in spi2dav
is not (or not properly) respected.
> marcel, is there a specific reason that you always pass the static SubscriptionInfo constant
(no node type filter, noLocal false) to the SubscribeMethod
> in spi2dav/RepositoryServiceImpl#createSubscription ?
> i guess this is the reason for the failure of
>   testNodeType(org.apache.jackrabbit.test.api.observation.AddEventListenerTest)
>   testNoLocalTrue(org.apache.jackrabbit.test.api.observation.AddEventListenerTest)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message