jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julian Reschke (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCR-2542) spi2dav: EventFilters not respected
Date Fri, 11 Nov 2011 15:28:51 GMT

    [ https://issues.apache.org/jira/browse/JCR-2542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148534#comment-13148534
] 

Julian Reschke commented on JCR-2542:
-------------------------------------

Update:

I tried to implement the isLocal flag as extension in the events returned by the POLL method
by comparing the session ID with the session associated with the event (as eĀ“found in the
EventImpl's EvenState).

This doesn't help, as we're comparing server sessions, which have a different lifetime from
those on the client. This could be made working by implementing complete session affinity
(one to one mapping between SPI session and server session), or by pickybacking SPI session
information to the JCR sessions so that it can be rediscovered in the event state.

The former sounds like a really bad idea just to make filtering on onLocal work.

The latter could be done in a similar way to JCR user data (extra request header, with the
data attached to the session object maybe as attribute), or even by piggybacking the information
to the user data.

                
> spi2dav: EventFilters not respected
> -----------------------------------
>
>                 Key: JCR-2542
>                 URL: https://issues.apache.org/jira/browse/JCR-2542
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-spi2dav, JCR 2.0, observation
>            Reporter: angela
>            Assignee: Julian Reschke
>
> i have the impression that the event filter passed to the event subscription in spi2dav
is not (or not properly) respected.
> marcel, is there a specific reason that you always pass the static SubscriptionInfo constant
(no node type filter, noLocal false) to the SubscribeMethod
> in spi2dav/RepositoryServiceImpl#createSubscription ?
> i guess this is the reason for the failure of
>   testNodeType(org.apache.jackrabbit.test.api.observation.AddEventListenerTest)
>   testNoLocalTrue(org.apache.jackrabbit.test.api.observation.AddEventListenerTest)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message