Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Received-SPF: pass (athena.apache.org: domain of stefan.guggisberg@gmail.com
 designates 209.85.213.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAAOnkMu0rgsvuhHLX+YRDMk5WHoBD4JHmLPGTHwUY7p3hF26cg@mail.gmail.com>
References: <20111013131939.176CC23889E3@eris.apache.org>
	<CAFYk8Nn7BCNrnMHAAsZ984kMYst1bivirFOvetFzuGAJ+ZtzqQ@mail.gmail.com>
	<CAAOnkMsJzAJMD1JEBsDbU8K28FcQnig-psat5E5EprcWP-aTkw@mail.gmail.com>
	<CAFYk8NmSxYC1_yxnet10UGyNJNOhma-ZciX2qF4XNGyR-iEGOw@mail.gmail.com>
	<CAAOnkMu0rgsvuhHLX+YRDMk5WHoBD4JHmLPGTHwUY7p3hF26cg@mail.gmail.com>
Date: Thu, 13 Oct 2011 17:53:43 +0200
Message-ID: 
 <CAFYk8NkOLdUuto+7-=1BXL-zWLS=sivO13wLuyZcRCwgMwRK8g@mail.gmail.com>
Subject: Re: svn commit: r1182835 - in
 /jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core:
 cache/AbstractCache.java cache/CacheManager.java
 persistence/bundle/AbstractBundlePersistenceManager.java
From: Stefan Guggisberg <stefan.guggisberg@gmail.com>
To: dev@jackrabbit.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 13, 2011 at 5:23 PM, Bart van der Schans
<b.vanderschans@onehippo.com> wrote:
> On Thu, Oct 13, 2011 at 4:51 PM, Stefan Guggisberg
> <stefan.guggisberg@gmail.com> wrote:
>> hi bart,
>>
>> On Thu, Oct 13, 2011 at 4:44 PM, Bart van der Schans
>> <b.vanderschans@onehippo.com> wrote:
>>> Hi Stefan,
>>>
>>> On Thu, Oct 13, 2011 at 4:27 PM, Stefan Guggisberg
>>> <stefan.guggisberg@gmail.com> wrote:
>>>>> - =A0 =A0 =A0 =A0if (log.isDebugEnabled()) {
>>>>> + =A0 =A0 =A0 =A0if (log.isInfoEnabled()) {
>>>>
>>>> what's the justification for changing the log level from debug to info=
?
>>>
>>> This is to make a distinction between the debug logging of the cache
>>> resizing which logs quite a bit of info every second and the logging
>>> of the cache (access/hit/miss) stats which log every minute
>>> (configurable). It's comparable to the logging of the stats of the
>>> bundle cache in 1.x which was also set on info.
>>
>> thanks for the explanation. i'd prefer to stick to the debug log level
>> for this kind of polled, i.e. repeating status information. the info
>> log level is
>> imo fine for logging single status change events (e.g. 'repository start=
ed')
>
> In general I agree. In this particular case, how can we log the stats
> on debug without flooding the logs with the debug output from the
> resizeAll() method?

ok, i get your point.

> Can we use TRACE log level for the resizing
> logging?

i guess yes, that's a good idea.

cheers
stefan

> Or is there some configuration trick in the logging (log4j)
> config that I'm missing that can be used to achieve that? I guess this
> "problem" will solve itself once we get the JMX bindings in place.
>
> Regards,
> Bart
>
>>
>> cheers
>> stefan
>>
>>>
>>> Regards,
>>> Bart
>