Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Received-SPF: pass (nike.apache.org: domain of julian.reschke@gmx.de
 designates 213.165.64.23 as permitted sender)
Message-ID: <4E900052.5070507@gmx.de>
Date: Sat, 08 Oct 2011 09:48:34 +0200
From: Julian Reschke <julian.reschke@gmx.de>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1
MIME-Version: 1.0
To: dev@jackrabbit.apache.org
CC: Dave Brosius <dbrosius@apache.org>
Subject: Re: CompareTo code seems odd, ok?
References: <4E8FC7F3.2050804@apache.org>
In-Reply-To: <4E8FC7F3.2050804@apache.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 2011-10-08 05:48, Dave Brosius wrote:
> This comparator seems odd to me, as it never returns (d) but perhaps i'm
> confused, is it ok?
>
> org.apache.jackrabbit.core.query.lucene.sort.ValueComparableWrapper
>
> public int compareTo(ValueComparableWrapper o) {
> final int d = compare(v, o.getValue());
> if (d != 0) {
> if (reversed) {
> return -d;
> }
> return -d;
> }
> return 0;
> }

It certainly looks broken. (If it's intended it would need a comment 
explaining why it is so)

Do we need a test before fixing?

Best regards, Julian