Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Date: Wed, 5 Oct 2011 14:31:34 +0000 (UTC)
From: "Julian Reschke (Commented) (JIRA)" <jira@apache.org>
To: dev@jackrabbit.apache.org
Message-ID: 
 <31246817.12008.1317825094111.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <176691865.11090.1317808895686.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (JCR-3091) Lucene Scorer implementations should
 handle the 'advance' to NO_MORE_DOCS optimisation better
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/JCR-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121007#comment-13121007 ] 

Julian Reschke commented on JCR-3091:
-------------------------------------

Maybe it would make sense to try to reduce all this code duplication; but that's it from my side :-)
                
> Lucene Scorer implementations should handle the 'advance' to NO_MORE_DOCS optimisation better
> ---------------------------------------------------------------------------------------------
>
>                 Key: JCR-3091
>                 URL: https://issues.apache.org/jira/browse/JCR-3091
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>         Attachments: JCR-3091.patch
>
>
> This is from the lucene Scorer (actually DocIdSetIterator) api:
> "NOTE: this method may be called with NO_MORE_DOCS for efficiency by some Scorers. If your implementation cannot efficiently determine that it should exhaust, it is recommended that you check for that value in each call to this method."
> None of the scorer implementations does that currently. Except for ChildAxisScorer thanks to JCR-3082.
> This is a worthwhile effort, which can save us from bugs (JCR-3082) but also leverage some performance optimisation hints from the lucene api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira