From dev-return-32608-apmail-jackrabbit-dev-archive=jackrabbit.apache.org@jackrabbit.apache.org Fri Oct 7 13:01:54 2011 Return-Path: X-Original-To: apmail-jackrabbit-dev-archive@www.apache.org Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 737F496DE for ; Fri, 7 Oct 2011 13:01:54 +0000 (UTC) Received: (qmail 68787 invoked by uid 500); 7 Oct 2011 13:01:54 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 68754 invoked by uid 500); 7 Oct 2011 13:01:54 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 68747 invoked by uid 99); 7 Oct 2011 13:01:54 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Oct 2011 13:01:54 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Oct 2011 13:01:51 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 36D562ADEFD for ; Fri, 7 Oct 2011 13:01:30 +0000 (UTC) Date: Fri, 7 Oct 2011 13:01:30 +0000 (UTC) From: "Alex Parvulescu (Commented) (JIRA)" To: dev@jackrabbit.apache.org Message-ID: <921618567.7699.1317992490225.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <512255981.7364.1317985109744.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (JCR-3098) Add hit miss statistics and logging to caches MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JCR-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122752#comment-13122752 ] Alex Parvulescu commented on JCR-3098: -------------------------------------- oh, I forgot something. About the element count: the cache already has memory used and max memory size which you can use to get an idea abut how filled up the cache is. so maybe we don't need to also log the actual element count. > Add hit miss statistics and logging to caches > --------------------------------------------- > > Key: JCR-3098 > URL: https://issues.apache.org/jira/browse/JCR-3098 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: jackrabbit-core > Reporter: Bart van der Schans > Fix For: 2.2.10, 2.3.1 > > Attachments: cache-stats.patch > > > The current caches (ConcurrentCache) doesn't maintain hit and miss statistics. This makes it very hard to know if you need to increase the caches in a deployment. This functionality does exist in the 1.5 and 1.6 branches, but is missing from the 2.x branches. The patch adds these statistics and adds logging on info level. The frequency of the logging is by default configured to maximal once a minute but can be configured with the system property "org.apache.jackrabbit.cacheLogStatsInterval" (in ms). > The log lines look like: > 07.10.2011 09:00:39 INFO [org.apache.jackrabbit.core.persistence.bundle.AbstractBundlePersistenceManager.logCacheStats():737] name=defaultBundleCache[ConcurrentCache@54fb02fd] num=21074 mem=34504k max=65536k hits=93352 miss=21074 puts=21135 > 07.10.2011 09:00:40 INFO [org.apache.jackrabbit.core.persistence.bundle.AbstractBundlePersistenceManager.logCacheStats():737] name=versionBundleCache[ConcurrentCache@47b1de1a] num=10637 mem=250k max=8192k hits=36352 miss=10637 puts=10637 > This patch will also make possible to later on expose these statistics over JMX when the initial JMX work has been settled. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira