From dev-return-32524-apmail-jackrabbit-dev-archive=jackrabbit.apache.org@jackrabbit.apache.org Wed Oct 5 11:57:58 2011 Return-Path: X-Original-To: apmail-jackrabbit-dev-archive@www.apache.org Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5F99A9B0D for ; Wed, 5 Oct 2011 11:57:58 +0000 (UTC) Received: (qmail 75283 invoked by uid 500); 5 Oct 2011 11:57:58 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 75225 invoked by uid 500); 5 Oct 2011 11:57:58 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 75217 invoked by uid 99); 5 Oct 2011 11:57:58 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Oct 2011 11:57:58 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Oct 2011 11:57:55 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 1E8722AAB7C for ; Wed, 5 Oct 2011 11:57:34 +0000 (UTC) Date: Wed, 5 Oct 2011 11:57:34 +0000 (UTC) From: "Julian Reschke (Commented) (JIRA)" To: dev@jackrabbit.apache.org Message-ID: <233594209.11338.1317815854127.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <752245275.7598.1317305565687.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (JCR-3087) InternalVersionHistoryImpl might throw RuntimeException MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JCR-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120853#comment-13120853 ] Julian Reschke commented on JCR-3087: ------------------------------------- It appears there's no problem here as RuntimeException indeed is a subclass of Exception and thus gets catched in RepositoryChecker.checkVersionHistory(). > InternalVersionHistoryImpl might throw RuntimeException > ------------------------------------------------------- > > Key: JCR-3087 > URL: https://issues.apache.org/jira/browse/JCR-3087 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: jackrabbit-core > Reporter: Julian Reschke > Assignee: Julian Reschke > > InternalVersionHistoryImpl.getVersion currently wraps RepositoryExceptions that occur on "reload()" into a RuntimeException. This may cause the RepositoryChecker to abort when attempting to fix a repository, defeating the point of running it. > I see two options: > 1) Add "throws RepositoryException" to the signature so no wrapping is needed; this *will* cause similar changes in various interfaces and implementations; but it appears to be straightforward. > 2) Modify the RepositoryChecker to catch RuntimeExceptions as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira