jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Julian Reschke <julian.resc...@gmx.de>
Subject Re: Curious method definition
Date Wed, 12 Oct 2011 08:17:30 GMT
On 2011-10-12 07:34, Dave Brosius wrote:
> The following method in class /
> /
>
>     /org.apache.jackrabbit.spi.commons.QNodeTypeDefinitionImpl /
>
> would appear to return a set of serializable property definitions.
>
> However, it would appear that it just returns a set-version of the
> passed in parameter, irrespective of whether the property defs are
> serializable or not.
>
> A naive view would say the else block shouldn't be there.
>
> If all property defs should be returned, there are much simpler ways to
> write this code.
> ...

Why do we even need to consider this case -- can't we just make 
QItemDefinition extends Serializable and kill this bit of complexity?

Best regards, Julian

Mime
View raw message