jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Julian Reschke <julian.resc...@gmx.de>
Subject Re: [jira] [Updated] (JCR-3069) add optional consistency checks to test suite
Date Tue, 11 Oct 2011 09:18:30 GMT
On 2011-10-07 18:03, Julian Reschke (Updated) (JIRA) wrote:
>
>       [ https://issues.apache.org/jira/browse/JCR-3069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
>
> Julian Reschke updated JCR-3069:
> --------------------------------
>
>      Attachment: JCR-3069.patch
>
> updated patch, incorporating changes and suggestions by Alex
> ...

A few updates:

- there's a set of Concurrent* tests that are currently disabled (and do 
not pass); after enabling them I was able to create an inconsistent 
persistence even on the BundleDBPersistenceManager; will investigate

- the check call takes around ~1s on my machine and will be much more 
expensive on bigger repositories, so we clearly can't run it always

- my current thinking is to add this as final dummy test to the test 
suite mentioned above; that wouldn't allow us to see what test caused 
the corruption but at least signal *that* it happened

- API: I'm tempted to change the Set<ReportItem> to Map<String, 
Set<ReportItem>>, in order to make the lookup by nodeId simpler. 
Feedback appreciated.

Best regards, Julian

Mime
View raw message