jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julian Reschke (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCR-3077) WeightedHighlighter does not encode XML markup characters
Date Tue, 20 Sep 2011 14:26:09 GMT

    [ https://issues.apache.org/jira/browse/JCR-3077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108740#comment-13108740

Julian Reschke commented on JCR-3077:

> a tiny feedback on your patch ;)


> I think it would be better if the test was in the "ExcerptTest" class.

Yep; I just did that.

> I like the "escape" refactoring.
>Why is it not static? Text.encodeIllegalXMLCharacters is static, what is the gain of adding
a non-static method to call a static one?

It needs to be non-static to that classes that extend from the DefaultHighLighter can override

> What is the benefit of making methods non static?

So that they can call the other methods I made non-static for the reason above :-) 

> WeightedHighlighter does not encode XML markup characters
> ---------------------------------------------------------
>                 Key: JCR-3077
>                 URL: https://issues.apache.org/jira/browse/JCR-3077
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-core
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>         Attachments: JCR-3077.patch, JCR-3077.patch, JCR-3077.patch
> See JCR-2611; the same problem applies to WeightedHighlighter.

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message