jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Parvulescu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCR-3040) JMX Stats for the Session
Date Fri, 19 Aug 2011 13:40:27 GMT

    [ https://issues.apache.org/jira/browse/JCR-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087706#comment-13087706
] 

Alex Parvulescu commented on JCR-3040:
--------------------------------------

hi all, 

I'm attaching a reworked version of the JMX support.
I'll attach it here, I see you like this task better, instead of the parent issue :)

The changes:
 - renamed to StatManager, as the core service will provide pure stats, and extra if needed
also expose them via jmx. Pure stats should give anybody the freedom they need to build tools
the way they need to.

 - there will be a system property 'enableJmxSupport' which will determine if the StatManager
should start the jmx Server not

 - the default JMX support will include just one bean called 'DynamicRegistry' (see JmxRegistry
for details), this allows anybody to enable jmx support for other Stats.
So you'll see (for now) 2 methods on the DynamicRegistry: enableCoreStatJmx and enableQueryStatJmx.

 - stats are disabled by default, this has nothing to do with JMX. If you want stats, you'll
have to enable them, if you want stats via jmx, enable the jmx support for that Stat object.

 - unit tests to provide a clearer example based on some code.

Again, I'm not looking for feedback on performance of the code (yet!). The point of this patch
was to build with the community's support a good starting point for stats/jmx, and to make
sure that collecting stats does not interfere with the raw performance.
As Stefan suggested, OOTB stats should be disabled, and without any impact on the core. To
me this is step one. Step 2 is what happens when you enable the stats :)

> sure, however that issue showed up as the first regression right after the commit (QED
;). 
Stefan, I have to say I'm sad that you would take a Java6 vs Java5 issue and turn it into
an argument against jmx support. It is as simple as that, it was (my) tiny mistake, which
I fixed after 5 mins of seeing it on the CI server.
But you have a good point, and now the Jmx is out of the default init of the repository.

Jukka, a dedicated branch for this effort sound great! How should be proceed?


> JMX Stats for the Session
> -------------------------
>
>                 Key: JCR-3040
>                 URL: https://issues.apache.org/jira/browse/JCR-3040
>             Project: Jackrabbit Content Repository
>          Issue Type: Sub-task
>          Components: jackrabbit-core
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>         Attachments: JCR-3040.patch, jr-test.log
>
>
> I've named them Core stats. This will include:
>  - number of sessions currently opened
>  - session read / write operations per second
> The stats refresh once a minute.
> This is disabled by default, so it will not affect performance.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message