jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Guggisberg (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCR-3040) JMX Stats for the Session
Date Thu, 18 Aug 2011 10:15:28 GMT

    [ https://issues.apache.org/jira/browse/JCR-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086931#comment-13086931
] 

Stefan Guggisberg commented on JCR-3040:
----------------------------------------

> I also don't see the regression risk, [...]

how about this one for example? ;)

<https://builds.apache.org/job/Jackrabbit-trunk/ws/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/jmx/query/QueryStatManager.java>:[107,37]
type javax.management.openmbean.OpenType does not take parameters

i am not a jmx expert but my gut feeling tells me that there could be potential issues with
different deployments/environments/etc...

that's why i don't like ootb jmx support. in your patch you're calling javax.management.*
code unconditionally from the RepositoryImpl constructor. 
IMO that should at least be made dependent on configuration. 

> JMX Stats for the Session
> -------------------------
>
>                 Key: JCR-3040
>                 URL: https://issues.apache.org/jira/browse/JCR-3040
>             Project: Jackrabbit Content Repository
>          Issue Type: Sub-task
>          Components: jackrabbit-core
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>         Attachments: JCR-3040.patch, jr-test.log
>
>
> I've named them Core stats. This will include:
>  - number of sessions currently opened
>  - session read / write operations per second
> The stats refresh once a minute.
> This is disabled by default, so it will not affect performance.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message