jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Guggisberg (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCR-3040) JMX Stats for the Session
Date Wed, 17 Aug 2011 15:24:27 GMT

    [ https://issues.apache.org/jira/browse/JCR-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086381#comment-13086381
] 

Stefan Guggisberg commented on JCR-3040:
----------------------------------------

thanks for the patch and sharing some test results!

WRT the results:
the spread of the test results is huge, i don't think that they allow any conclusion WRT to
the potential performance impact.

WRT the patch:
i agree with thomas's comments. apart from those i've got a few remarks 
regarding the RepositoryImpl changes: 

- i'd prefer to move the sessionCreated() and sessionLoggedOut() calls outside
  of the 'synchronized (activeSessions) {}' block. 

- MBeanServer.registerMBean() is called  on every startup, whether the stats are enabled or
not.
  i'd prefer if that call would only be made depending on e.g. a system property.

WRT to adding JMX support to jackrabbit core:

just based on 'slight interest' i'm rather reluctant adding major features to jackrabbit core
with considerable risk of causing regressions.

> JMX Stats for the Session
> -------------------------
>
>                 Key: JCR-3040
>                 URL: https://issues.apache.org/jira/browse/JCR-3040
>             Project: Jackrabbit Content Repository
>          Issue Type: Sub-task
>          Components: jackrabbit-core
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>         Attachments: JCR-3040.patch, jr-test.log
>
>
> I've named them Core stats. This will include:
>  - number of sessions currently opened
>  - session read / write operations per second
> The stats refresh once a minute.
> This is disabled by default, so it will not affect performance.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message