jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Mueller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCR-3040) JMX Stats for the Session
Date Thu, 18 Aug 2011 10:13:27 GMT

    [ https://issues.apache.org/jira/browse/JCR-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086929#comment-13086929
] 

Thomas Mueller commented on JCR-3040:
-------------------------------------

> - 10% slower?

I compared the 50% times. Example: test 4 no changes, ConcurrentReadWriteTest: 1902; with
changes: 2317. Well, I don't even know if the numbers are "ms" or "op/s" - you tell me :-)

> premature optimization

My comments are about simplicity and not that much about performance. Simplifying the code
almost always makes sense. Simplifying early makes a lot of sense, because people tend to
be afraid to simplify 'working' code later on. 

Using double instead of BigDecimal just simpler. Avoiding divisions in methods that are called
very often also seems logical, specially if the resulting code is actually simpler and better
(that is: always correct, which it's not currently). Using volatile versus locks is also about
simplicity, plus it avoids nasty deadlocks.

The rest of my comments are also not really about performance.


> JMX Stats for the Session
> -------------------------
>
>                 Key: JCR-3040
>                 URL: https://issues.apache.org/jira/browse/JCR-3040
>             Project: Jackrabbit Content Repository
>          Issue Type: Sub-task
>          Components: jackrabbit-core
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>         Attachments: JCR-3040.patch, jr-test.log
>
>
> I've named them Core stats. This will include:
>  - number of sessions currently opened
>  - session read / write operations per second
> The stats refresh once a minute.
> This is disabled by default, so it will not affect performance.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message