jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Parvulescu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCR-2959) SQL2 QueryEngine should use Lucene for sort
Date Fri, 12 Aug 2011 18:29:27 GMT

    [ https://issues.apache.org/jira/browse/JCR-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084294#comment-13084294
] 

Alex Parvulescu commented on JCR-2959:
--------------------------------------

I've updated JCR-3047, so in order for the patch to still work, please replace 'String p =
evaluator.getAffectedPropertyName' with 'String p = o.toString()'

Yes, currently the sort is still done in JR, but it is extremely easy to fallback on native
lucene fields (I just have to figure out how to know when that is available or not)

I believe that having a native sort would benefit more in the long term, as it will allow
for other performance improvements (see also JCR-2830)
I'd aim at having equivalent run times in worst case scenarios, and be good on some of the
worst performing scenarios, so that sql2 stops being the underdog in this query language wars
:)
And I find it hard to believe that the improvement is just a fluke.

I agree with the fact that we need to test some more, this is why the patch is a working prototype.
I'll go for the test scenario you proposed, so we can see what turns up.

> SQL2 QueryEngine should use Lucene for sort
> -------------------------------------------
>
>                 Key: JCR-2959
>                 URL: https://issues.apache.org/jira/browse/JCR-2959
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: 2.2.1
>            Reporter: Robert Seidel
>            Priority: Minor
>         Attachments: JCR-2959.patch
>
>
> Currently all SQL2 queries with "order by" expression are sorted with Collections.sort
- which is slow and very bad if there are lots of hits. Lucene should be used for sorting
hits instead.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message