Return-Path: X-Original-To: apmail-jackrabbit-dev-archive@www.apache.org Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 368B8685F for ; Thu, 21 Jul 2011 18:59:23 +0000 (UTC) Received: (qmail 68371 invoked by uid 500); 21 Jul 2011 18:59:22 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 68157 invoked by uid 500); 21 Jul 2011 18:59:22 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 67971 invoked by uid 99); 21 Jul 2011 18:59:21 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Jul 2011 18:59:21 +0000 X-ASF-Spam-Status: No, hits=-2001.1 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Jul 2011 18:59:19 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 000F24E775 for ; Thu, 21 Jul 2011 18:58:57 +0000 (UTC) Date: Thu, 21 Jul 2011 18:58:57 +0000 (UTC) From: "Julian Reschke (JIRA)" To: dev@jackrabbit.apache.org Message-ID: <405792844.12410.1311274737997.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <348055937.41181.1309070987430.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (JCR-3004) Check if a DAV-Request has a Label in the header, before checking if it's version-controlled MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JCR-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069132#comment-13069132 ] Julian Reschke commented on JCR-3004: ------------------------------------- I would recommend to drop support for the Label header. See : 8.3_ LABEL_HEADER ... The Label header has poorly defined semantics when used with Depth header, and is inconsistent with HTTP variant processing. ... Replace the Label header with a DAV:labeled-version report. and draft in > Check if a DAV-Request has a Label in the header, before checking if it's version-controlled > -------------------------------------------------------------------------------------------- > > Key: JCR-3004 > URL: https://issues.apache.org/jira/browse/JCR-3004 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: jackrabbit-jcr-server > Affects Versions: 2.2.7, 2.3.0 > Reporter: Christian Stocker > Assignee: angela > Fix For: 2.3.0 > > Attachments: patch_commit_85c91801358a.patch > > > When looking at our MySQL logs, I realized that jackrabbit on each DAV Request calls the VERSION table every time I get a new node (which is not cached yet), even if I only do a simple getNode. > As a versioning table can get pretty large, this may have a performance impact. > I found out, that DavResourceFactoryImpl checks, if a node is versioned to decide, if we have to check for the Label header to later check out another version for the GET request. I re-ordered those checks now so that it first checks, if there's an http Label-header and only then checks, if the node is versioned. The check for a Label header should be much faster than checking a DB, if it's versioned (and scale much better, too) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira