jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Reutegger (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (JCR-2916) Avoid String.intern() when indexing
Date Tue, 22 Mar 2011 11:03:05 GMT

    [ https://issues.apache.org/jira/browse/JCR-2916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009611#comment-13009611

Marcel Reutegger commented on JCR-2916:

Generally the patch look OK.

I've identified two issues:
- IndexMigrationTest (line 71) and NodeIndexer (line 745): the field names still need to be
interned. The names are not one of the already interned constants.

Regarding Term usage: I think we should create a separate issue for that.

> Avoid String.intern() when indexing
> -----------------------------------
>                 Key: JCR-2916
>                 URL: https://issues.apache.org/jira/browse/JCR-2916
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Marcel Reutegger
>            Priority: Minor
>         Attachments: JCR-2916-fields.patch
> Lucene 3.0 now allows to create Fields with a String name that is already interned. We
should use the new constructor in NodeIndexer to avoid unnecessary String.intern() calls.
The field names Jackrabbit uses are available in FieldNames and already interned.

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message