jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jukka Zitting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-2910) Please add JackrabbitSession.isAdmin
Date Tue, 08 Mar 2011 13:20:59 GMT

    [ https://issues.apache.org/jira/browse/JCR-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003925#comment-13003925

Jukka Zitting commented on JCR-2910:

> backup the repository, or change the configuration

The code that actually implements these features should already have access to internal methods
like SessionImpl.isAdmin(), so I don't see why we'd need to expose it to external clients.

The API we expose for these operations should simply throw exceptions if the user doesn't
have enough access rights. If the user interface needs to be able to determine whether the
current user is allowed to perform such operations (for example to grey out or hide certain
UI elements), it should use the Session.hasCapability() method for that.

> Please add JackrabbitSession.isAdmin
> ------------------------------------
>                 Key: JCR-2910
>                 URL: https://issues.apache.org/jira/browse/JCR-2910
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>            Reporter: Thomas Mueller
>            Priority: Minor
> Currently finding out if the session user is an admin requires:
> JackrabbitSession js = (JackrabbitSession) session;
> User user = ((User) js.getUserManager().getAuthorizable(session.getUserID()));
> boolean isAdmin = user.isAdmin();
> Or: ((SessionImpl) session).isAdmin(). However casting to an implementation is problematic
for several reasons.
> I think it would make sense to add isAdmin() to the JackrabbitSession interface, so the
code above would be:
> ((JackrabbitSession) session).isAdmin()

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message