Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 73627 invoked from network); 17 Feb 2011 09:57:51 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 17 Feb 2011 09:57:51 -0000 Received: (qmail 24208 invoked by uid 500); 17 Feb 2011 09:57:50 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 24041 invoked by uid 500); 17 Feb 2011 09:57:48 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 24026 invoked by uid 99); 17 Feb 2011 09:57:47 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Feb 2011 09:57:47 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Feb 2011 09:57:45 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id A26C31AAAFB for ; Thu, 17 Feb 2011 09:57:24 +0000 (UTC) Date: Thu, 17 Feb 2011 09:57:24 +0000 (UTC) From: "Stefan Guggisberg (JIRA)" To: dev@jackrabbit.apache.org Message-ID: <349203744.2283.1297936644661.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <2058390910.18309.1297796097888.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] Assigned: (JCR-2891) VersionManagerImplRestore internalRestoreFrozen method has identity versus equals bug MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JCR-2891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Guggisberg reassigned JCR-2891: -------------------------------------- Assignee: Stefan Guggisberg > VersionManagerImplRestore internalRestoreFrozen method has identity versus equals bug > ------------------------------------------------------------------------------------- > > Key: JCR-2891 > URL: https://issues.apache.org/jira/browse/JCR-2891 > Project: Jackrabbit Content Repository > Issue Type: Bug > Components: jackrabbit-core > Affects Versions: 2.2.2 > Environment: Exists in 2.2.4 version of code base (as well as 2.3) > Reporter: Matt Goodwin > Assignee: Stefan Guggisberg > Fix For: 2.2.2 > > Original Estimate: 10m > Remaining Estimate: 10m > > In method protected void internalRestoreFrozen(NodeStateEx state, > InternalFrozenNode freeze, > VersionSelector vsel, > Set restored, > boolean removeExisting, > boolean copy) > in the VersionManagerImplRestore class line 557 the code performs an == instead of calling the NodeId.equals() method. We ran into problems with the code that executes below this (trying to restore a folder node throws an ItemExistsException since same sibling not allowed on folder nodes) -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira