Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 6840 invoked from network); 1 Mar 2011 02:28:01 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 1 Mar 2011 02:28:01 -0000 Received: (qmail 52504 invoked by uid 500); 1 Mar 2011 02:28:00 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 52406 invoked by uid 500); 1 Mar 2011 02:27:59 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 52398 invoked by uid 99); 1 Mar 2011 02:27:59 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Mar 2011 02:27:59 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Mar 2011 02:27:57 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id E3DBD427B5 for ; Tue, 1 Mar 2011 02:27:36 +0000 (UTC) Date: Tue, 1 Mar 2011 02:27:36 +0000 (UTC) From: "Xiaoming Shi (JIRA)" To: dev@jackrabbit.apache.org Message-ID: <2050367652.3756.1298946456928.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] Created: (JCR-2905) DateFormat.getDateTimeInstance() is very expensive, we can cache it to improve performance MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org DateFormat.getDateTimeInstance() is very expensive, we can cache it to improve performance ------------------------------------------------------------------------------------------ Key: JCR-2905 URL: https://issues.apache.org/jira/browse/JCR-2905 Project: Jackrabbit Content Repository Issue Type: Bug Components: jackrabbit-core Affects Versions: 2.2.2 Reporter: Xiaoming Shi DateFormat.getDateTimeInstance() is very expensive, we can cache it to improve performance In the file: ./jackrabbit-2.2.2/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/observation/EventJournalImpl.java line: 356 DateFormat.getDateTimeInstance() is called in a critical section. We can move it outside the critical section to increase the concurrency. It's better for us to add a class member field to store the value. This is similar to the Apache bug: https://issues.apache.org/bugzilla/show_bug.cgi?id=48778 -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira