jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-2228) JSR 283 LifeCycle Management
Date Wed, 15 Dec 2010 09:28:03 GMT

    [ https://issues.apache.org/jira/browse/JCR-2228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971592#action_12971592
] 

angela commented on JCR-2228:
-----------------------------

thanks for the patch. i quickly had a look at it and based on that very first glance i have
two following concerns: 

1) you simply forward the follow followLifecycleTransition call to the RepositoryService without
making sure that the Workspace (and 
    in particular the Node) being target of the lifecycle is properly updated after the operation.
    the specification states "This method may change the value of the jcr:currentLifecycleState
property [...]".
    you may take a look at other workspace operations to solve this.

2) the specification in addition states 
    "The Node interface provides the following methods related to lifecycles. If the node
does not have the mix:lifecycle mixin, the methods 
     will return UnsupportedRepositoryOperationException."
     I would prefer to have this initially checked on the client side in order to avoid unnecessary
SPI roundtrips. 

> JSR 283 LifeCycle Management
> ----------------------------
>
>                 Key: JCR-2228
>                 URL: https://issues.apache.org/jira/browse/JCR-2228
>             Project: Jackrabbit Content Repository
>          Issue Type: Sub-task
>          Components: jackrabbit-jcr2spi, jackrabbit-spi, JCR 2.0
>    Affects Versions: 2.3.0
>            Reporter: angela
>         Attachments: lifecycle.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message