Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Message-ID: <15330479.51761289051264432.JavaMail.jira@thor>
Date: Sat, 6 Nov 2010 09:47:44 -0400 (EDT)
From: "Stefan Guggisberg (JIRA)" <jira@apache.org>
To: dev@jackrabbit.apache.org
Subject: [jira] Assigned: (JCR-2807) ConcurrentModificationException in
 SessionItemStateManager.getIdOfRootTransientNodeState()
In-Reply-To: <25244844.51601289048744307.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/JCR-2807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Guggisberg reassigned JCR-2807:
--------------------------------------

    Assignee: Stefan Guggisberg

> ConcurrentModificationException in SessionItemStateManager.getIdOfRootTransientNodeState()
> ------------------------------------------------------------------------------------------
>
>                 Key: JCR-2807
>                 URL: https://issues.apache.org/jira/browse/JCR-2807
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>    Affects Versions: 2.1.2
>            Reporter: Weston Bustraan
>            Assignee: Stefan Guggisberg
>
> SessionItemStateManager.getIdOfRootTransientNodeState() is throwing a ConcurrentModificationException on line 607:
> Here's a snippet of the code:
> {code}
>                     for (NodeId id : candidateIds) {
>                         if (nodeId.equals(id) || hierMgr.isAncestor(id, nodeId)) {
>                             // already a candidate or a descendant thereof
>                             // => skip
>                             skip = true;
>                             break;
>                         }
>                         if (hierMgr.isAncestor(nodeId, id)) {
>                             // candidate is a descendant => remove
>                             candidateIds.remove(id);
>                         }
>                     }
> {code}
> Can't use Collection.remove(Object) in the middle of iterating. It should probably be changed to use Iterator.remove():
> {code}
>                     Iterator<NodeId> nodeIdItor = candidateIds.iterator();
>                     while (nodeIdItor.hasNext()) {
>                         NodeId id = nodeIdItor.next();
>                         if (nodeId.equals(id) || hierMgr.isAncestor(id, nodeId)) {
>                             // already a candidate or a descendant thereof
>                             // => skip
>                             skip = true;
>                             break;
>                         }
>                         if (hierMgr.isAncestor(nodeId, id)) {
>                             // candidate is a descendant => remove
>                             nodeIdItor.remove();
>                         }
>                     }
> {code}
> Any idea what I could do differently to workaround the issue?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.