jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jukka Zitting (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (JCR-2719) Incorrect outer join TCK tests
Date Wed, 24 Nov 2010 16:07:13 GMT

     [ https://issues.apache.org/jira/browse/JCR-2719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Jukka Zitting resolved JCR-2719.

    Resolution: Fixed
      Assignee: Jukka Zitting

Resolving as fixed. Adding new tests to jcr-tests is a bit troublesome when we don't have
a new JCR spec version coming up.

> Incorrect outer join TCK tests
> ------------------------------
>                 Key: JCR-2719
>                 URL: https://issues.apache.org/jira/browse/JCR-2719
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-jcr-tests
>    Affects Versions: 2.0.0, 2.1.0, 2.1.1
>            Reporter: Jukka Zitting
>            Assignee: Jukka Zitting
>            Priority: Minor
>             Fix For: 2.2.0
> The TCK test cases for outer joins seem to be incorrect. More specifically the expected
result sets for the testRightOuterJoin1() and testLeftOuterJoin2() test cases in EquiJoinConditionTest
are invalid, as shown below:
> * testRightOuterJoin1() result set {{null, n1}, {n1, n2}, {n2, n2}} --> The n1 node
does not have the propertyName2 property set, so the first tuple can never occur regardless
of the join type. And since n2 already matches existing nodes, even {null, n2} can not be
included in the result set. The correct result set for this query seems to be {{n1, n2}, {n2,
> * testLeftOuterJoin2() result set {{n1, null}, {n2, n1}, {n2, n2}} --> Same as above,
a tuple with n1 as the leftmost node is not possible. The correct result set would be {{n2,
n1}, {n2, n2}}.
> Unfortunately the correct result sets here don't actually exercise the outer join functionality,
i.e. none of the nodes in the returned tuples are null. We'll need to modify the test case
setup to fix this.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message